Repository navigation
Build the Riverbank Drawings view - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the approved Drawings view (HIS-13, Paper p-4-1) and deletes the drawings list look it replaces.
List. Drawings gets its own cards: a 148px card with a 90px thumbnail of the actual drawing (fitted to its bounds, ink in the theme's text colour), a Shantell title and a "Today · 15:38" meta line, with the sticky tilt and the 1.5 selected border. List view gets rows with a small thumbnail. Both faces exist only in Drawings; drawings in My notes keep the ordinary note face. The media filter is gone from Drawings, since everything in it is a drawing.
New in Drawings makes a drawing. The window bar reads "Drawings N" with "New drawing ⌘N", search reads "Find a drawing…", and ⌘N, the page toolbar's New and an empty pane's New all make a drawing while Drawings is open (a note everywhere else). It opens in draw mode without focusing an editor and the list stays in Drawings.
Empty states. An empty Drawings list shows "No drawings yet", the line from the proposal and a tonal New drawing button, replacing the old
emptyMessagepath; a search with no hits reads "No matching drawings". With nothing open, the page shows "No drawing open / Start one with New drawing or ⌘N".Canvas. Shantell 28/36 title with "Edited today, 15:38 · N shapes", a faint dot grid in
controlBorder, and a tool dock in the insert bar's styling using the app's real glyphs, with the active tool in tonal sage. The colour and size popover offers Ink, Clay, Ochre, Sage, River and Plum, and Thin, Medium and Bold (2/4/8, as before). Tool keys, undo, redo and zoom are unchanged.Deviations from Paper. The tool glyphs are the app's own rather than the proposal's stand-ins, as asked. List-row meta uses the list's existing time format ("15:38") rather than the card's "Today · 15:38". Switching to Drawings still leaves an open note on the page, as switching spaces always has, so "No drawing open" shows only when nothing is open; the page toolbar keeps Share greyed there rather than removed, as it does for every empty page.
Tests. Four new goldens cover the gallery in dark (
desktop_dark_drawings) and light with the colour and size popover open (desktop_light_drawings_style), the list view (desktop_dark_drawings_list), and both empty states together (desktop_dark_drawings_empty). New widget tests in the spaces rail group check that, while Drawings is open, the empty list's New drawing, the window bar's New drawing, ⌘N and the page toolbar's New each open a fresh drawing note, and that the media filter shows in Notes and not in Drawings. The shortcut on the empty page is printed as a keycap, like every other shortcut hint.Checks.
flutter analyzeis clean, and the fullflutter testsuite passes locally (2144 passed, 8 skipped) on Flutter 3.47.4 withpub get --enforce-lockfile, since the 3.47.2 install on this Mac is damaged. No existing goldens moved. The Drawings test inapp_test.dartnow asserts that New in Drawings makes a drawing. Rendered offscreen at 1440×900; no app was launched.Dark cards:

Light, with the colour and size popover:

List view:

Empty:
