Fix not following RFC6763 section 6.3#103
Open
mgirard1mtx wants to merge 1 commit into
Open
Conversation
… as its own constitent string (each len + strings is a key/value pair).
Author
|
Here is an example dig answer to a TXT request: In this case the TXT RData contains 4 strings which are each key value pairs:
|
Author
|
@kapetan do I need to do something for that p.r. ? The txt have a slight bug where multi Txt record are not handle properly (we treat the list of key value as a single key value pair). |
|
@kapetan: Have you seen this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC6763 section 6.3:
Specifies that each key/value pair is encoded as its own constituent string. So each bytes length + string is a key value pair.
I tested this with an IPMX registry device.
Before the fix the Attribute where mangled (a single key/pair).
After the proposed fix each Key Value pairs matches the output from standard tools like dig.