Conversation
|
Things that need looking into: |
We should (maybe) consider doing that on mac, too. I am not 100% sure. The days o x86_64 macs might be over. So even touchting that might be not worth the time. I don't think that many developers have a need to run Toolbox2Docker on macOS. |
He, He , I use macOS. Haven't used windows for development since 2021. Docker CLI is compiled for macOS arm64 and I can build docker-machine for macOS arm64 as well. That just leaves creating an arm64 port of boot2docker. As I don't have a modern arm based mac just lot of Intel macs this hasn't been a priority. |
|
I use UTM on my M1 mac mini. It's super simple to setup a arm64 Linux. You just have todo a:
I have no idea how vbox (arm64 - if such a thing exists) compares to UTM. Correct me if I am wrong - for this PR I doubt that we have to care about a macOS Lite version. |
No arm for Virtualbox.
No macOS for this PR. |
|
Is there anything missing? Do I have todo anything to make progress here? |
There are virtualbox references all over the Installer in Toolbox.iss in the windows directory. This needs to be looked at when I have time.
Ensure that the installer looks and functions correctly if you're able to. |
Yes but we simply disable them via sed. We don't display them in the UI and we don't package anything in the setup.
The functions are there - but we never call them.
This is also ugly - because it's doesn't look like a magic string - it is a magic string. RUN if [ "$VARIANT" = "-lite" ]; then \
sed -i 's|^#define MyAppName "Toolbox2docker"|#define MyAppName "Toolbox2docker'$VARIANT'"|g' Toolbox.iss; \
sed -i 's|^AppId=.*$|AppId={{5DFD8320-1E10-11EF-9E35-0800200C9A66}|g' Toolbox.iss; \
sed -i 's|^Name: vbox_ndis5;|// Name: vbox_ndis5;|g' Toolbox.iss; \
sed -i 's|^Name: "VirtualBox";|// Name: "VirtualBox";|g' Toolbox.iss; \
sed -i 's|^Source: "{#virtualBoxMsi}"|// Source: "{#virtualBoxMsi}"|g' Toolbox.iss; \
sed -i 's|Wizardform\.ComponentsList\.|// Wizardform\.ComponentsList\.|g' Toolbox.iss; \
fi && \
wine ../innosetup/ISCC.exe Toolbox.iss /DMyAppVersion=$INSTALLER_VERSION /DMixpanelToken=$MIXPANEL_TOKEN |
|
Any progress here? |
1 similar comment
|
Any progress here? |
|
Any updates here? |
PoC for Lite version
AppId={{FC4417F0-D7F3-48DB-BCE1-F5ED5BAFFD91}looked somehow odd - as it has only one closing bracket - but it's correct https://stackoverflow.com/posts/61174457/revisions (please double check - I am no expert).Ping me if I need to add changes.