feat: refine card activity feed controls by separating notes/comments - #527
feat: refine card activity feed controls by separating notes/comments#527scoobs-mystery-bytes wants to merge 3 commits into
Conversation
|
Great start @NDCallahan Few bits of feedback:
Give me a shout if I can help with anything |
So, it appears, there might need to be additions to the API. I'm definiely not a programming expert on the backend. Here's what I think is needed based on review. Please let me know how far off base that I am. Proposed SolutionPhase 1: API EnhancementExtend the // Input Parameters
{
cardPublicId: string // Required, existing
limit?: number // Optional, existing (1-100, default: 10)
cursor?: string // Optional, existing (ISO datetime for pagination)
filter?: 'all' | 'activity' | 'comments' // NEW
sortOrder?: 'asc' | 'desc' // NEW (default: 'desc')
}
// Response (unchanged structure)
{
activities: ActivityItem[]
hasMore: boolean
nextCursor: string | null
}Phase 2: Backend ImplementationModify the
Filtering Logic: Phase 3: Frontend UpdatesModify
|
|
That sounds correct to me @NDCallahan Give me a shout if I can help with anything |
… to allow for pagination
|
@hjball - When you have some time, I have made the requested changes. Let me know your thoughts, requests, modifications, likes, dislikes, or if we look good! :) |
|
Hey there @hjball. Checking in to see if you have had a chance to look at this again. |
|
Sorry for the delay @NDCallahan - will take a look at this one tomorrow |
hjball
left a comment
There was a problem hiding this comment.
Apologies again for the delay on this one @scoobs-mystery-bytes - I've found a bug when testing -> sortOrder doesn't actually reorder the query and breaks pagination
Description
Separates activity from comments/notes for better organization and sorting. This improves the card view by giving users a dedicated activity feed that's distinct from user comments and notes, making it easier to track changes and updates. Additionally the activies can be sorted.
Type of change
Checklist
Linked issue
Closes #525
Screenshots
Short Video of functionality