Add opt-in infinite retries with elapsed-time guard#120
Open
kamui wants to merge 3 commits into
Open
Conversation
Closed
kamui
force-pushed
the
feat/infinite-retries
branch
from
e758f8e to
73cb938
Compare
kamui
force-pushed
the
feat/infinite-retries
branch
from
591a500 to
e121ead
Compare
Support infinite retry loops bounded by max_elapsed_time, useful for long-running worker processes. Raises ArgumentError if max_elapsed_time is not finite or if custom intervals are empty. Extracts interval_for on ExponentialBackoff for lazy per-attempt interval computation without pre-allocating an array.
kamui
force-pushed
the
feat/infinite-retries
branch
from
e121ead to
4acdaa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tries: :infinitewithout changing existing finite retry defaultsmax_elapsed_timeto be finite when infinite retries are enabledTesting
bundle exec rspecbundle exec rubocop lib/retriable.rb lib/retriable/exponential_backoff.rbbundle exec rubocop spec/exponential_backoff_spec.rbgit diff --check