ported v1model test#21
Conversation
kamleshbhalui
force-pushed
the
v1model_to_dpdk_test_port
branch
from
c1426f4 to
704f616
Compare
kamleshbhalui
force-pushed
the
v1model_to_dpdk_test_port
branch
from
704f616 to
8510d19
Compare
kamleshbhalui
requested review from
github-sajan,
psivanup,
syogender and
usha1830
usha1830
left a comment
usha1830
left a comment
There was a problem hiding this comment.
I see more .spec files than the test P4 files. Why is that?
We would need to check what the tests are doing and avoid repetitions as much as possible.
Also we need to see what to do about Copyright.
| "Error compiling" | ||
| testdata/p4_16_samples/psa-dpdk-issue2314.p4 | ||
| ) | ||
|
|
There was a problem hiding this comment.
All failing cases with same fail message used as regex should be combined
| @@ -0,0 +1,100 @@ | |||
| /* | |||
There was a problem hiding this comment.
I am not sure what the copyright message should be. Also this file does not include psa.p4, not required?
| @@ -0,0 +1,72 @@ | |||
| /* | |||
There was a problem hiding this comment.
While porting, we should ignore the tests which does not involve any backend processing. This will not compile with ./p4c-dpdk I assume and our regression script will not run this, does it?
|
The purpose of this porting is to find any latent bugs. So, lets do some initial analysis of the failures and file JIRA issues. |
2 participants
No description provided.