Repository navigation
fix: freeze denominator-aligned unit field contract - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolved_activity_value/unitas the authoritative factor-denominator-aligned application quantityresolved_quantity_kgto mean kilograms only and keep it null for non-mass activitygCO2e/kgCO2e/tCO2epreview numerators tokgCO2e/g,/kg, or/tbefore approval and lockingScope
This is an independent stacked PR based on PR #23 at
2f6b52c9effda67a73862b9dca1d3d88487cd8a7. It does not change retrieval, ranking, aliases, qualification, factor values, candidate IDs, frozen answers, or approval decisions. It does not merge PR #23.Verification
24cf05884cc29358ceb57eeece42ed4585eb466aQA history
The first independent QA pass found one reference-flow alignment issue, an inconsistent-kg lock gap, and a finite-input overflow gap. The second pass found tiny-value tolerance, missing-dimension and legacy-fallback variants. These failures remain preserved in review history. The third exact-head re-review at
24cf0588passed with no P0/P1/P2 or residual P3 findings.