Fix readFile bypass for https urls in Xml::build() - #87
Merged
kamilwylegala merged 1 commit intoSep 18, 2026
Merged
Conversation
The condition read
$options['readFile'] && strpos($input, 'http://') === 0 || strpos($input, 'https://') === 0
and && binds tighter than ||, so the https branch was never gated by the
option: Xml::build($input, array('readFile' => false)) still went out and
fetched an input beginning with https://. Only the http:// branch was
actually disabled.
RequestHandlerComponent passes readFile => false when it decodes an XML
request body, so an application that accepts XML input can be made to
issue an outbound https request to a host of the caller's choosing.
Parenthesised so both schemes are gated as the option intends, and the
existing readFile url test gains its https twin.
Owner
|
Thanks @iglocska for your contribution 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xml::build()gates URL loading on thereadFileoption, but the condition is&& binds tighter than ||, so this evaluates as (readFile && http) || (https). The https://
branch is never gated, and Xml::build($input, array('readFile' => false)) still performs an
outbound request.