replaced deprecated stdlib functions

[xepa]

replaced is_domain_name and all validate_* with more modern versions

Fixes #76

---

This change is 

[maxadamo]

@xepa could you please fix this one as well:
https://github.com/kakwa/puppet-samba/blob/master/manifests/log.pp#L14

it should become:

unless $sambaclassloglevel =~ Hash

@kakwa would you mind reviewing this commit, also considering the change that I am proposing, and creating a new release?

[maxadamo]

more changes needed:
https://github.com/kakwa/puppet-samba/blob/master/manifests/log.pp#L14

unless $sambaclassloglevel =~ Hash

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @xepa)

[xepa]

thank you @maxadamo for pointing out the missing is_hash fix

[xepa]

Is there anything that I can do to expedite a merge ?

[maxadamo]

@kakwa are willing to review this change?

[xepa]

@kakwa would it be possible that you can take a look at this PR and merge / tag ? I will CC @bastelfreak (as contributor) maybe he can take on this request.

[bastelfreak]

Hi,
I've no merge powers here.

[bastelfreak]

my recommendation is to add the datatypes to the class parameters,that makes the whole file shorter and enabled puppet-strings to pick up the types for the automatic documentation.

[maxadamo]

agree with the above comment. But, unless any objection from @kakwa , we may want to fork this module. @bastelfreak do we have Samba in voxPupuli?
The module uses old fashioned language style now.

[bastelfreak]

Vox Pupuli doesn't have a samba module. I suggest you hop into our IRC or Slack channel and ask around. I think there are some more people that use a samba module, but I don't know which one.

[kakwa]

@maxadamo @bastelfreak I will check on IRC/Slack and discuss the possibility of transferring full ownership of this module.

I'm completely ok with a fork btw, but a full ownership transfer would be preferable IMHO, including the Puppet Forge Stuff if still relevant.

I will try to ping you on IRC in the next few days. Nick Kakwa, already joined the IRC channel.

edit: did the etymology, I love your project name.

[xepa]

Is there something that I can do to expedite the merger of this PR ? (it has been a while now .. and I would really like to switch back to the official version instead of my branch)

[iainhallam]

@kakwa @maxadamo @bastelfreak Did anything come of moving this module to Vox Populi?