Skip to content

add ability to override package names#54

Open
miguelwhite wants to merge 1 commit into
kakwa:masterfrom
miguelwhite:mjb-20180501-override_params
Open

add ability to override package names#54
miguelwhite wants to merge 1 commit into
kakwa:masterfrom
miguelwhite:mjb-20180501-override_params

Conversation

@miguelwhite

@miguelwhite miguelwhite commented May 1, 2018

Copy link
Copy Markdown

This change is Reviewable

@kakwa

kakwa commented May 18, 2018

Copy link
Copy Markdown
Owner

Sorry for the delay.

I'm wondering if it would be possible to factorize this part and only make samba::params configurable:

https://github.com/kakwa/puppet-samba/blob/master/manifests/params.pp

if custom packages are needed, just instantiate samba::params with additional parameters. I'm not sure it will work but this module used to do something close when it was handling installation from sernet packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants