Add optional AMap POI service and contributor setup docs - #8
Merged
Conversation
RCF-117
marked this pull request as ready for review
July 7, 2026 07:18
kaikkd
approved these changes
Aug 18, 2026
kaikkd
left a comment
Owner
There was a problem hiding this comment.
本地复核通过:后端 60 项测试通过,前端 10 项测试通过,生产构建通过。高德响应解析、无 Key 降级、缓存和 SQLite 父目录处理整体清晰;留一条非阻塞的数据契约建议。
|
|
||
| def _poi_out(p) -> dict: | ||
| return { | ||
| "amap_id": p.amap_id, |
Owner
There was a problem hiding this comment.
[P3] 请把 amap_id 继续透传到前端候选/排程链路
这里开始返回真实高德 ID,但当前 frontend/src/api/client.ts 的 toPoi() 仍固定写入 amap_id: null,SelectedPoiPayload 和后端 SelectedPoi 也没有该字段。因此 /plan/candidates 返回的 ID 在用户选中 POI 后立即丢失,后续反查、去重或 grounding 无法使用这次新增的数据。
这不阻塞当前展示,所以作为非阻塞建议:让 toPoi 使用 p.amap_id ?? null,并在 selected POI payload 与排程转换中继续透传;如果本 PR 有意只负责后端,请至少建立跟踪 issue。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/CONTRIBUTING.mdand align local setup docs arounduv, project-local caches, and health-check smoke testsamap_servicefor AMap Web Service POI lookup with TTL caching and stub fallbackNotes
AMAP_KEYremains optional. Without it, local development and tests continue to use the existing stub data.Validation
uv run pytest-> 60 passednpm test -- --run-> 10 passednpm run build-> passed/health->200 {'status': 'ok'}