Repository navigation
feat: show skill startup diagnostics - #200
Conversation
98d7a05 to
d5d6093
Compare
Squashed from origin/feat/skill-startup-diagnostics (d5d6093) onto upstream/main.
|
Not merged yet. Generated by Claude Code |
Use OMP live resolution instead of duplicating discovery. Keep the native notice preference and never resume stopped sessions for inspection.
Add an icon-only dismiss button that hides the current report until its diagnostics change, and shorten the disable action to "Turn this off" so the notice text keeps its width on phones.
773062c to
9fc786c
Compare
|
Integration rebase onto current upstream exposed a stale anthropicSlowMode state field and two cached conflict resolutions missing test closures. Removed the obsolete field (the provider-neutral slowMode fields are already retained) and restored the test boundaries without weakening assertions. Verification: typecheck passed; RPC manager, native settings, and hook RPC suites passed all 214 tests. These repairs are on this PR branch so integration rebuilds retain them. |
Squashed from origin/feat/skill-startup-diagnostics (38c2104) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (38c2104) onto upstream/main.
|
Verification for head
The failed upstream Windows build matches the known Next.js Google-font URL parsing bug, vercel/next.js#99114. I reproduced the exact TypeError with the installed Next.js loader by supplying an extensionless font URL; the Older OMP compatibility: I tested the actual PR route handlers and process wrapper with a real released, unpatched OMP 18.6.1, in isolated HOME/agent directories with no credentials or model calls. Its state omits I also checked the browser against released 18.1.17: saved transcripts, settings, reload/reconnect, and ordinary non-model RPC remain usable. Manual diagnostics show the localized unavailable message, not a fabricated clean report. Caveat for that older release: its unknown-command replies omit request IDs, so inspection takes the existing five-second timeout and can show an |
Squashed from origin/feat/skill-startup-diagnostics (38c2104) onto upstream/main.
|
Shortened the startup warning action to Turn off and anchored the accessible 24px dismiss button in the warning’s top-right corner, outside the action-row flex flow. Browser-verified the actual component with compiled app CSS at 320, 768, 1024 and 1440px: no horizontal overflow; Details, dismissal and Turn off all work. Focused diagnostics tests (3), TypeScript and component ESLint pass. Condensed adversarial review: no findings. |
Squashed from origin/feat/skill-startup-diagnostics (9dbf567) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (9dbf567) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (9dbf567) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (9dbf567) onto upstream/main.
|
Reverted the warning × positioning to its original inline action-row layout, as requested. Kept Turn off unchanged. Actual component/CSS browser smoke at 320px and 1440px confirms inline placement without overflow; diagnostics tests (3), TypeScript and component ESLint passed. Condensed review: no findings. |
Squashed from origin/feat/skill-startup-diagnostics (444e413) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (444e413) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (444e413) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (444e413) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (444e413) onto upstream/main.
Squashed from origin/feat/skill-startup-diagnostics (444e413) onto upstream/main.
What
Show OMP's skill conflict and redundant-installation diagnostics above the composer when its RPC session starts. Details show the resolved default, namespaced variants, retained identical copies, paths, sources and selection reason.
Add an × button that dismisses the notice for the session until the reported diagnostics change, a Turn this off action, and a native Skill startup notices setting. Manual inspection stays available for a selected running session in Settings → Extensions & Tools → Skills while automatic notices are off; it never resumes a stopped session. English, Japanese and Simplified Chinese labels are included.
Why
Companion to can1357/oh-my-pi#14148. OMP remains the only resolver: this consumes the new RPC query/state/update frames, without a second collision detector or a separate browser preference. An empty new-chat page does not spawn OMP solely for diagnostics. Older binaries report manual diagnostics as unavailable rather than falsely clean.
Testing
npm test: 1,128 passed, 5 skipped, zero failures.npm run typecheck: passed.npm run lint: zero errors, 11 unchanged baseline warnings (not a zero-warning gate).next buildor deployment was performed, per the development rules.Runtime requirement
Requires an OMP runtime supporting
get_skill_diagnostics,set_skill_startup_diagnostics,get_state.skillDiagnostics, andskill_diagnostics_updatefrom the linked PR. This does not change the existing CLI skill listing fallback.