fix(samples): correct env and secretRefs format in production security sample#133
Open
tmohanvamsi wants to merge 1 commit intokagent-dev:mainfrom
Open
Conversation
…y sample The mcpserver-production-security.yaml sample had two incorrect field formats: 1. 'env' was using []corev1.EnvVar format (list with name/value) but the actual MCPServerDeployment type defines it as map[string]string 2. 'secretRefs' had non-existent 'key' and 'envName' fields - the actual type is []corev1.LocalObjectReference which only has a 'name' field 3. Removed non-existent 'mcpServer' section at the end of the spec These incorrect examples would cause users to create invalid MCPServer resources that would fail validation. Signed-off-by: tadepmo <tmohanvamsi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
mcpserver-production-security.yamlsample had incorrect field formats that would cause users to create invalid MCPServer resources.Issues Fixed
envwrong format — sample used[]corev1.EnvVar(list withname/value) butMCPServerDeployment.Envis defined asmap[string]stringsecretRefswrong fields — sample had non-existentkeyandenvNamefields; actual type is[]corev1.LocalObjectReferencewhich only hasnamemcpServersection — removed stale spec section that doesn't exist in the CRDImpact
Users following this sample would get validation errors when applying to a cluster.
Testing
Documentation/sample only change. Verified field types against
api/v1alpha1/mcpserver_types.go.Related Issue
Related to #93