Repository navigation
fix: a miss in a T!E function with a non-String E stops the program - #1404
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1400.
Inside a
T!function, an index miss, a map key miss,.value()on none, or a badxs[i] = vfails the function with a String message. The emitter did this for every fallible function, so aT!Efunction with a structEreturned that String where anEbelonged. Reading a field of the error then crashed.Misses now fail the function only when its error type is
T!orT!String. With any otherEthey stop the program with the usual runtime error, as they do outside a fallible function. Inside an isolated HTTP or gRPC handler that fails the request, which covers generated gRPC handlers (Resp!grpc.GrpcError)..value()cases.docs/idiomatic_pith.mddescribes the rule.