Repository navigation
perf: drop closure and constant-divisor checks that cannot fail - #1402
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closure calls and constant division carried checks that could only pass:
make_adder's lambda the body went from 26 instructions to 10.f(f(x))testsfonce. The cache is keyed by the local that holds the closure, dropped when that local is stored to, and cleared at every label.i % 7.Measured against main (
t2.sh, 5 interleaved rounds, median ms):Under callgrind, closure_calls goes from 218M to 140M instructions and closure_error from 892M to 773M. A call through a closure now costs the same as a direct call in closure_calls.
Building maps and sets in place, which was planned for this change, is left out: it cost event_ledger 8% in timing with no gain anywhere, even though it ran fewer instructions.
The local suite passes, including both leak gates and memcheck.
Refs #986