Repository navigation
fix: refuse argument labels and interface value types the compiler ignored, and dispatch tag-only enum methods - #1397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three shapes the compiler used to accept and then get wrong:
f(b: 1, a: 5)bound by position and a label naming no parameter compiled. A label must now name the parameter in its position (E314), on functions, methods and generic functions. A call through a function value takes no labels, since the value has no parameter names.implon an enum without payloads passed the checker and then failed in the backend with "call to unknown function". Such an enum is an integer to the emitter, which lost the type name it dispatches on. The receiver now keeps the enum's name when its impl declares the method.docs/errors.mddocuments both new codes. Regression cases cover methods on a tag-only enum (with arguments, through a field and a list element, and through an interface impl), matching labels, and the two invalid shapes.