Replace retired Go Report Card badge - #73
Merged
Merged
Conversation
added 3 commits
September 8, 2026 08:54
The Go Report Card service has been retired and its README badge is no longer useful. Remove the badge and add a golangci-lint workflow. Replicates k0swe/kel-agent#181.
- parser.go: replace ineffectual 'err' assignments with '_' where the error was already being discarded (ineffassign). Error propagation is unchanged: the final assignment before each return still uses err. - Suppress ST1012 on exported error vars ParseError / NotConnectedError with //nolint and a reason: renaming them would break the published v4 module's public API. All existing tests pass; no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go Report Card service has been retired and its README badge is no longer useful.
golangci-lintGitHub Actions workflow to lint on push/PR tov4(this repo's default branch).Replicates k0swe/kel-agent#181.