Skip to content

fix: correct codeql warnings#196

Merged
mdevolde merged 1 commit into
jxmorris12:masterfrom
mdevolde:fix/codeql_warns
Jun 20, 2026
Merged

fix: correct codeql warnings#196
mdevolde merged 1 commit into
jxmorris12:masterfrom
mdevolde:fix/codeql_warns

Conversation

@mdevolde

@mdevolde mdevolde commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

fix: correct codeql warnings

Why the pull request was made

To correct some warnings from codeql, about code quality.

See:
https://github.com/jxmorris12/language_tool_python/security/code-scanning/1
https://github.com/jxmorris12/language_tool_python/security/code-scanning/2
https://github.com/jxmorris12/language_tool_python/security/code-scanning/3
https://github.com/jxmorris12/language_tool_python/security/code-scanning/4
https://github.com/jxmorris12/language_tool_python/security/code-scanning/5
https://github.com/jxmorris12/language_tool_python/security/code-scanning/6
https://github.com/jxmorris12/language_tool_python/security/code-scanning/7

Summary of changes

Patched these warns:

  • __eq__ not overridden when adding attributes
  • Module is imported with 'import' and 'import from'
  • Should use a 'with' statement
  • Statement has no effect
  • Unused global variable

Screenshots (if appropriate):

Not applicable.

How has this been tested?

Applied local tests.

Resources

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation only)
  • Refactor / code style update (non-breaking change that improves code structure or readability)
  • Tests / CI improvement (adding or updating tests or CI configuration only)
  • Other (please describe):

Checklist

  • Followed the project's contributing guidelines.
  • Updated any relevant tests.
  • Updated any relevant documentation.
  • Added comments to your code where necessary.
  • Formatted your code, run the linters, checked types and tests.

* `__eq__` not overridden when adding attributes
* Module is imported with 'import' and 'import from'
* Should use a 'with' statement
* Statement has no effect
* Unused global variable
@mdevolde mdevolde self-assigned this Jun 20, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.48%. Comparing base (80c4c71) to head (dc16d03).

Files with missing lines Patch % Lines
src/language_tool_python/download_lt.py 81.81% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   80.52%   80.48%   -0.04%     
==========================================
  Files          13       13              
  Lines        1725     1732       +7     
==========================================
+ Hits         1389     1394       +5     
- Misses        336      338       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdevolde mdevolde merged commit 635708c into jxmorris12:master Jun 20, 2026
13 checks passed
@mdevolde mdevolde deleted the fix/codeql_warns branch June 20, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants