fix: correct codeql warnings#196
Merged
Merged
Conversation
* `__eq__` not overridden when adding attributes * Module is imported with 'import' and 'import from' * Should use a 'with' statement * Statement has no effect * Unused global variable
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 80.52% 80.48% -0.04%
==========================================
Files 13 13
Lines 1725 1732 +7
==========================================
+ Hits 1389 1394 +5
- Misses 336 338 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct codeql warnings
Why the pull request was made
To correct some warnings from codeql, about code quality.
See:
https://github.com/jxmorris12/language_tool_python/security/code-scanning/1
https://github.com/jxmorris12/language_tool_python/security/code-scanning/2
https://github.com/jxmorris12/language_tool_python/security/code-scanning/3
https://github.com/jxmorris12/language_tool_python/security/code-scanning/4
https://github.com/jxmorris12/language_tool_python/security/code-scanning/5
https://github.com/jxmorris12/language_tool_python/security/code-scanning/6
https://github.com/jxmorris12/language_tool_python/security/code-scanning/7
Summary of changes
Patched these warns:
__eq__not overridden when adding attributesScreenshots (if appropriate):
Not applicable.
How has this been tested?
Applied local tests.
Resources
Not applicable.
Types of changes
Checklist