refactor: makes internal utilities private#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: makes internal utilities private
Why the pull request was made
In prevision of the breaking release, move some internal utilities to a private module, and makes other internal stuff private by renaming them.
This PR is a breaking change.
Having private stuff ensure that we can modify them as we want without having to make a breaking release.
Summary of changes
_internals._compatto_internals/compatutilsto_internals/utils(keep autilsmodule to expose some utilities likecorrect).api_typesto_internals/api_types.safe_zipto_internals/safe_zip.match.is_check_matchfunction to be able to correctly typeMatch.__init__(in casual situations, a user doesn't need to create matches by himself but because Match creation is public, tools to do it must be available).Screenshots (if appropriate):
Not applicable.
How has this been tested?
Applied local tests.
Resources
Not applicable.
Types of changes
Checklist