Repository navigation
Conversation
|
Please review the logic, last PR was compiled fine over kernels from 6.3 to 6.12+ |
46a0287 to
a95c06f
Compare
|
Sorry, I removed the 4-arg call for kernels 6.3–6.8, which broke the kernel 6.6 CI build. That was my fault. And those pr wont compile in my armbian build that made by ophub, probably due to gcc 14.2 and Ophub Armbian kernel 6.12.103 may have backported the set_monitor_channel signature change from mainline 6.13 into 6.12. The CI's mainline 6.12.104 headers might still have the old signature. my essential fix is just >= 6.12.0 instead of >= 6.13.0 And also i replaced deprecated/removed strncpy calls with strscpy across all driver files with cfg80211 API Signature Adaptations. |
|
and also it seems like gh workflow build on kernel 6.18.45 and 6.12.104 failed to download, i havent looked at it yet |
|
Hi. I have reviewed the PR.
|
…6.9+, 6.12+, 7.2+ 1. Replace deprecated strncpy with safe strscpy across all driver files (hal_com.c, hal_com_phycfg.c, hal_sdio.c, phydm_debug.c, rtw_debug.c, rtw_wlan_util.c, os_intfs.c, ioctl_cfg80211.c, ioctl_linux.c, rtw_cfgvendor.c) to fix implicit function declaration build errors on Kernel 6.8+, 6.12+, and 7.2+. Add a fallback macro for kernels < 4.3 in osdep_service_linux.h. 2. ioctl_cfg80211.c: Clarify cfg80211_ch_switch_notify logic for Kernel 6.9+ (3 arguments: dev, chandef, flags). 3. ioctl_cfg80211.c: Lower version guard for set_monitor_channel dev parameter from KERNEL_VERSION(6, 13, 0) to KERNEL_VERSION(6, 12, 0). 4. ioctl_cfg80211.c: Update remain_on_channel signature for Kernel 7.2+ by adding const u8 *rx_addr parameter.
a95c06f to
d9fb743
Compare
|
Thanks for reviewing my PR. I revert the workflow dispatch and revise the commit message, will it do? |
In Linux kernel 6.9+ and 6.12,
cfg80211_ch_switch_notifyrequires 4 arguments.The upper bound check
< KERNEL_VERSION(6, 9, 0)inos_dep/linux/ioctl_cfg80211.ccaused kernels >= 6.9.0 to fall back to the 3-argument variant, leading to a build error (too few arguments to function 'cfg80211_ch_switch_notify').Removing the
< KERNEL_VERSION(6, 9, 0)check allows Kernel 6.3 through 6.12+ to use the 4-argument signature and build cleanly.