Fix IOS running onBeforeNextPlaylistItem callback on initial video load #220
Open
normtronics wants to merge 2 commits intojwplayer:masterfrom
Open
Fix IOS running onBeforeNextPlaylistItem callback on initial video load #220normtronics wants to merge 2 commits intojwplayer:masterfrom
normtronics wants to merge 2 commits intojwplayer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
On IOS, when using the onBeforeNextPlaylistItem callback it fires on the first item when the video is initially loaded. The functionality should run on the next playlist item after the first and so on. The PR adjust the logic so it the callback fires after the the first video.
Why is this Pull Request needed?
This will stop the callback from getting run on the first initial video.
Are there any points in the code the reviewer needs to double check?
Are there any Pull Requests open in other repos which need to be merged with this?
Addresses Issue(s):
GitHub Issue