Skip to content

fix build error on nightly-2025-04-25#73

Merged
jvdd merged 3 commits intojvdd:mainfrom
JosiahWhite:fix-nightly-compile-error
May 7, 2025
Merged

fix build error on nightly-2025-04-25#73
jvdd merged 3 commits intojvdd:mainfrom
JosiahWhite:fix-nightly-compile-error

Conversation

@JosiahWhite
Copy link
Copy Markdown
Contributor

No description provided.

@JosiahWhite
Copy link
Copy Markdown
Contributor Author

Seems like a portion of the tests are failing due to the Rand dep needing updated, and the others are failing to build due to ndarray depending on the broken version of this crate.

How do you suggest I resolve this?

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 7, 2025

CodSpeed Performance Report

Merging #73 will not alter performance

Comparing JosiahWhite:fix-nightly-compile-error (2b78a0e) with main (585c5cf)

Summary

✅ 168 untouched benchmarks

@jvdd
Copy link
Copy Markdown
Owner

jvdd commented May 7, 2025

Thanks for submitting this PR @JosiahWhite

I fixed up the tests and had to update 1 more type for float16 data types (this got only triggered when building with --all-features, as f16 is not a native rust data type).

@jvdd jvdd merged commit 664ba92 into jvdd:main May 7, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants