Replace error-deferred for HEAD implementation#322
Open
tggreene wants to merge 1 commit intojuxt:masterfrom
Open
Replace error-deferred for HEAD implementation#322tggreene wants to merge 1 commit intojuxt:masterfrom
tggreene wants to merge 1 commit intojuxt:masterfrom
Conversation
Currently we're creating deferred errors which are never consumed (these log exceptions when the next GC cycle runs), instead we can simply throw to be caught be the outer deferred chain and handled in the normal catch block in yada.handler/handle-request-with-maybe-subresources. The only distinction from existing behaviour is that we will now return a 406 in line with GET when we have no available representation for the HEAD, whereas previously we would return a 200. This aligns with the principle that the HEAD response should reflect the GET other than providing a response body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we're creating deferred errors which are never consumed (these log
exceptions when the next GC cycle runs), instead we can simply throw exceptions to be
caught be the outer deferred chain and handled in the normal catch block in
yada.handler/handle-request-with-maybe-subresources.The only distinction from existing behaviour is that we will now return a 406 in
line with GET when we have no available representation for the HEAD, whereas
previously we would return a 200.
This aligns with the principle that the HEAD response should reflect the GET
other than providing a response body.
This PR should address #206.