fix bug with transfer-encoding: chunked#220
Open
d-t-w wants to merge 1 commit intojuxt:masterfrom
d-t-w:chunked-encoding
Open
fix bug with transfer-encoding: chunked#220d-t-w wants to merge 1 commit intojuxt:masterfrom d-t-w:chunked-encoding
d-t-w wants to merge 1 commit intojuxt:masterfrom
d-t-w:chunked-encoding
Conversation
Author
|
I should add I found this issue when attempting to receive data via a PUT with chunked encoding, e.g. And noting the |
|
The reason for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc for yada.interceptors/process-request-body says:
"Therefore we process the request body if the request contains a Content-Length or Transfer-Encoding header, regardless of the method semantics."
Current implementation does not process the request body if there is a Transfer-Encoding header (indicating chunked) and no Content-Length header, valid per HTTP 1.1 (see: conditional on line 174).
This PR causes yada.request-body/process-request-body to be called if the request contains either header, in line with the doc-string.
If the consumer in the original impl was intended to deal with chunked encoding, be aware that as long as the underlying Netty pipeline includes the HttpObjectAggregator then Netty will take care of that chunking aggregation for you.