Restrict model-facing patch-loop admission to validated findings - #196
Open
justsml wants to merge 1 commit into
Open
Restrict model-facing patch-loop admission to validated findings#196justsml wants to merge 1 commit into
justsml wants to merge 1 commit into
Conversation
Owner
Author
|
Council review summary: five loops completed. The first three established that the complete ACP tracer is too large and unsafe to expose as one quick repair; loops four and five reviewed this containment diff. Final independent reviewers reported no blockers. This PR is intentionally limited to server-resolved validated-Finding admission at the model-facing boundary. #70 remains open for the app-owned explicit-request action, confined runner, evidence verification, resume, streaming, and teardown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
explicitRequestandrequestedByfields from acting as user authorityWhy
The existing service foundation intentionally supports explicit user requests, but the model-facing tool exposed free-form request identity as an admission gate. That allowed the model to manufacture authority. This PR closes that containment gap without activating the incomplete ACP runtime.
Verification
git diff --checkpassedFull repository type-checking is currently blocked by an unrelated existing error in
tests/integration/agent-controller-session-release.test.ts:52(deleteSessionis absent onAgentController).Scope
This is a containment repair only. It does not add the explicit-request UI/server action, enable an ACP process, or claim completion of streaming, evidence collection, deterministic verification, resume, or teardown.
Refs #70