update - #2
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces tuigreet with noctalia-greeter, removes agenix and its associated secrets, switches the filesystem configuration from btrfs to ext4, and updates various system configurations including the CachyOS kernel package, swap devices, and Git signing settings. Feedback is provided to improve code quality by removing commented-out code in the kernel configuration and replacing a hardcoded home directory path with a dynamic configuration variable in the Wayvibes module.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # nix.settings.substituters = [ "https://attic.xuyh0120.win/lantian" ]; | ||
| # nix.settings.trusted-public-keys = [ | ||
| # "lantian:EeAUQ+W+6r7EtwnmYjeVwx5kOGEBpjlBfPlzGlTNvHc=" | ||
| # ]; |
| enable = true; | ||
| soundpack = "/home/hiepnh/proj/wayvibes/soundpacks/cherrymx-red-abs"; | ||
| volume = 3; | ||
| soundpack = "/home/hiepnh/Projects/wayvibes/soundpacks/cherrymx-red-abs"; |
There was a problem hiding this comment.
Avoid hardcoding the user's home directory path (/home/hiepnh). Instead, use ${config.home.homeDirectory} to make the configuration portable and robust across different environments or user names. Note that you may need to ensure config is declared in the module's input arguments (e.g., { config, ... }).
soundpack = "${config.home.homeDirectory}/Projects/wayvibes/soundpacks/cherrymx-red-abs";
No description provided.