Skip to content

update - #2

Merged
justanoobcoder merged 5 commits into
mainfrom
dev
Jul 6, 2026
Merged

update#2
justanoobcoder merged 5 commits into
mainfrom
dev

Conversation

@justanoobcoder

Copy link
Copy Markdown
Owner

No description provided.

@justanoobcoder
justanoobcoder merged commit 09a96ff into main Jul 6, 2026
0 of 2 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces tuigreet with noctalia-greeter, removes agenix and its associated secrets, switches the filesystem configuration from btrfs to ext4, and updates various system configurations including the CachyOS kernel package, swap devices, and Git signing settings. Feedback is provided to improve code quality by removing commented-out code in the kernel configuration and replacing a hardcoded home directory path with a dynamic configuration variable in the Wayvibes module.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +15 to +18
# nix.settings.substituters = [ "https://attic.xuyh0120.win/lantian" ];
# nix.settings.trusted-public-keys = [
# "lantian:EeAUQ+W+6r7EtwnmYjeVwx5kOGEBpjlBfPlzGlTNvHc="
# ];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Commented-out code should be removed to keep the configuration clean and maintainable. Since these settings are no longer used, they can be safely deleted.

enable = true;
soundpack = "/home/hiepnh/proj/wayvibes/soundpacks/cherrymx-red-abs";
volume = 3;
soundpack = "/home/hiepnh/Projects/wayvibes/soundpacks/cherrymx-red-abs";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid hardcoding the user's home directory path (/home/hiepnh). Instead, use ${config.home.homeDirectory} to make the configuration portable and robust across different environments or user names. Note that you may need to ensure config is declared in the module's input arguments (e.g., { config, ... }).

      soundpack = "${config.home.homeDirectory}/Projects/wayvibes/soundpacks/cherrymx-red-abs";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant