Skip to content

docs: mark P2/P3 done, and P4 with its measured per-repo state - #9

Merged
hunterdsp merged 3 commits into
mainfrom
docs/mark-p2-p3-done
Jul 31, 2026
Merged

docs: mark P2/P3 done, and P4 with its measured per-repo state#9
hunterdsp merged 3 commits into
mainfrom
docs/mark-p2-p3-done

Conversation

@hunterdsp

Copy link
Copy Markdown
Contributor

The phase checklist still showed P2–P4 unticked, so the plan understated progress while overstating what is left.

  • P2 ✅build: adopt the cross-org Makefile standard (P2) doppler-dsp/doppler#558 plus four follow-ups. 50 hand-maintained targets → 0 shared + 25 local; help 30-of-50 (advertising two that did not work) → 67-of-67 generated. Entry records the two config-surface gaps doppler could not express (docs-check cannot accumulate; the build step has no flag surface, so an adopting C repo silently drops to one job) and the adoption-by-copy trap that left doppler unguarded for a day.
  • P3 ✅skills://makefile-convention rewritten alongside #558, plus four sibling skills that named the renamed targets.
  • P4 ⬜ — in progress, with measurements instead of a guess:
repo run: steps make plumbing unclassified
doppler 74 29 39 6
just-makeit 71 5 24 42

doppler's remaining 6 are 3 CI-native and 3 release-path (deliberately deferred — those steps only run during a release, so an error is invisible until it is expensive). just-makeit's 42 are mostly artifact.yml scaffold-smoke steps driving the jm CLI, which is the per-repo judgement P4 asks for rather than an omission.

Also recorded: two inline duplications P4 surfaced that a target-count audit misses — docs.yml reimplementing make gen-c-api and already diverging from it (uv run mkdocs vs uv run --group docs mkdocs; a cp that merged where the target replaces, so a deleted C symbol's page survived forever in the deployed site), and make test-python selecting a different test set from CI's pytest — the RFC's own complaint surviving the port meant to end it.

P2 and P3 landed (doppler-dsp/doppler#558 plus four follow-ups; the convention
doc alongside it) but the checklist still read as untouched, so the plan
understated progress while overstating what remained.

P4 stays open, now with numbers rather than a guess: doppler is at 29 make /
6 unclassified across all workflows (3 CI-native, 3 release-path deferred on
purpose), just-makeit at 5 make / 42 unclassified, most of which drive the jm
CLI rather than its own build.

Each entry carries what the phase actually taught, in the style P0/P1 set:
the two config-surface gaps doppler could not express, the adoption-by-copy
trap that left it unguarded for a day, and the two inline duplications P4
surfaced that a target-count audit misses.
The table still showed only the 2026-07-30 baseline and the target, so it could
not answer "where are we?" — which is the question it exists for.

Eight of ten are met. The two that are not are recorded with their reason
rather than as bare misses:

* Criterion 1 (26 vs <=18) is a stale TARGET, not a failed port. The estimate
  predates migration step 6, which required seven of doppler's 26 local
  targets; hitting <=18 now would mean pushing gates back into inline CI.
  Proposes replacing the number with the invariant that actually holds and is
  gate-enforced: LOCAL_TARGETS declares exactly what the Makefile defines.
* Criterion 4 is P4, measured per repo for the first time: doppler 6/74
  unclassified, just-makeit 42/71.

Criterion 9 is upgraded from "behaves identically" to byte-identical, since
both repos now vendor the same file verified against canonical.
@hunterdsp
hunterdsp force-pushed the docs/mark-p2-p3-done branch from 605b3a7 to 8838ce1 Compare July 31, 2026 12:24
@hunterdsp
hunterdsp merged commit bf772c9 into main Jul 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant