docs: make criterion 1 a property, not a count - #8
Merged
Conversation
"≤18 / ≤1" was a count of local targets, and a count is not a quality signal. A repo legitimately grows local ones — doppler added seven binary-hygiene gates in a single afternoon, moving its remainder from 19 to 26 — so the criterion reads as failing while nothing has drifted, and a criterion that goes stale on healthy activity gets ignored rather than fixed. The property that actually matters is already stated in its own text: no shared target defined in a repo Makefile, every local one declared in LOCAL_TARGETS. Criterion 10 covers the shared set, and it is 0. Phase status is left alone: it belongs to whoever owns the phase. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XLuSsmv88aheh7mNQgBDQK
hunterdsp
force-pushed
the
docs/tick-p2-p3
branch
from
July 31, 2026 12:00
3b5ba40 to
8dba8ea
Compare
hunterdsp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewritten and narrowed. The first version of this PR ticked P2/P3 and wrote a doppler target count into criterion 1. Both were out of my lane, and the count was stale within the hour — doppler added seven binary-hygiene gates, moving its remainder from 19 to 26. Phase status now stays with whoever owns the phase.
What is left is one plan-mechanics fix.
Criterion 1 becomes a property, not a count
≤18 / ≤1counted local targets. A count is not a quality signal: a repo legitimately grows local targets, so the criterion reads as failing while nothing has drifted — and a criterion that goes stale on healthy activity gets ignored rather than fixed.The property is already in the criterion's own text: no shared target defined in a repo Makefile, and every local one declared in
LOCAL_TARGETS. The shared set is what must not drift, and that is criterion 10, currently 0.Target column is now
0 shared.