docs: adoption means curl canonical, never cp a sibling - #7
Merged
Conversation
The Required-files table said `standard.mk` is "vendored verbatim" without saying verbatim FROM WHERE, and that gap is how the second adopter ended up unguarded on its first day. doppler adopted by taking the file from just-makeit's working tree. At that moment it held the pre-publication copy, where `STANDARD_URL` was still empty and opt-in. Nothing went red: the copy passed every gate and reported `standard-check: inert`, which reads like a pass. doppler ran for a day with no drift protection at all while its `make lint` was green — precisely the fail-open that making the URL a default was meant to eliminate. The default only works if the adopter fetches the file that carries it. So the adoption step is now spelled out as one command, with the two consequences that cost time here: * arming-by-default protects only an adopter that vendors the CURRENT canonical, because a copy from a sibling carries that sibling's arming policy as of whenever it was taken; * after canonical changes, adopters do not update themselves — their gate goes red, which is correct and is the point. The fix is to re-fetch, never to edit the vendored copy. An adopter whose gate is INERT is the one case that will not tell you. Fixed in doppler by re-vendoring: doppler-dsp/doppler#559.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Required-files table says
standard.mkis "vendored verbatim" without saying verbatim from where — and that gap is how the second adopter ended up unguarded on its first day.doppler adopted by taking the file from just-makeit's working tree, which at that moment held the pre-publication copy where
STANDARD_URLwas still empty and opt-in. Nothing went red: the copy passed every gate and reportedwhich reads like a pass. doppler ran for a day with no drift protection at all while its
make lintwas green — exactly the fail-open that making the URL a default was meant to eliminate. Fixed by re-vendoring (doppler-dsp/doppler#559).The default only works if the adopter fetches the file that carries it, so adoption is now one explicit command:
with the two consequences that cost time here spelled out: