Handle kernel dead status message in iopub polling#349
Open
dualc wants to merge 1 commit into
Open
Conversation
When a kernel dies, the gateway server broadcasts an iopub status message with execution_state="dead". Previously this message was silently discarded because it doesn't match the current cell's parent_msg_id. Now _async_poll_output_msg checks for the dead status before filtering by parent_msg_id, and cancels task_poll_for_reply to trigger DeadKernelError in the main execution flow. This mirrors how _async_poll_kernel_alive handles kernel death detection. This is particularly important for Jupyter Gateway/Enterprise Gateway deployments where the kernel runs on a remote server and the local KernelManager may not detect death through other channels promptly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a kernel dies, the gateway server broadcasts an iopub status message with execution_state="dead". Previously this message was silently discarded because it doesn't match the current cell's parent_msg_id.
Now _async_poll_output_msg checks for the dead status before filtering by parent_msg_id, and cancels task_poll_for_reply to trigger DeadKernelError in the main execution flow. This mirrors how _async_poll_kernel_alive handles kernel death detection.
This is particularly important for Jupyter Gateway/Enterprise Gateway deployments where the kernel runs on a remote server and the local KernelManager may not detect death through other channels promptly.