Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

Allow passing of alert id into configObj#62

Open
timmygee wants to merge 1 commit into
juliancwirko:masterfrom
timmygee:master
Open

Allow passing of alert id into configObj#62
timmygee wants to merge 1 commit into
juliancwirko:masterfrom
timmygee:master

Conversation

@timmygee

@timmygee timmygee commented Feb 6, 2018

Copy link
Copy Markdown

Currently you cannot use your own alertIds when creating a notification. This is problematic if you have a react component as the message to be displayed and you want it to be dismissible by a close handle. There is no way to know the alertId at the component level because it is not passed in and the only way to dismiss the notification would be via the closeAll() method which is not ideal if there's more than one notification displayed.

This PR allows id to be passed in via the configObj and falls back to normal behaviour if it's not present.

My solution will be to pass in an id generated by sAlertTools.randomId() and should be the recommended way. I have imported it into my code via. You may wish to provide a better interface.

import sAlertTools from 'react-s-alert/dist/s-alert-parts/s-alert-tools';

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant