This repository was archived by the owner on Mar 14, 2020. It is now read-only.
Allow passing of alert id into configObj#62
Open
timmygee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently you cannot use your own
alertIds when creating a notification. This is problematic if you have a react component as the message to be displayed and you want it to be dismissible by a close handle. There is no way to know thealertIdat the component level because it is not passed in and the only way to dismiss the notification would be via thecloseAll()method which is not ideal if there's more than one notification displayed.This PR allows id to be passed in via the
configObjand falls back to normal behaviour if it's not present.My solution will be to pass in an id generated by
sAlertTools.randomId()and should be the recommended way. I have imported it into my code via. You may wish to provide a better interface.import sAlertTools from 'react-s-alert/dist/s-alert-parts/s-alert-tools';