This repository was archived by the owner on Mar 14, 2020. It is now read-only.
add style field#34
Open
turtleDev wants to merge 1 commit into
Open
Conversation
add style field
Owner
|
Hi, thanks. I couldn't find time to get back to this tool lately. I hope I'll be able to review this one and others asap :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a
stylefield to your npm package makes it compatible with sass-module-importer, which is a nice way to import css into your sass project directly fromnode_moduleswithout relying on the ugly../../imports.I would also recommend compiling a
react-s-full.cssfile (that includes everything needed to use react-s-alert, including animations), and then set that as thestylefor your module.The CSS files are not so big to warrant them being in their separate files, or at least for me, it was counter-intuitive. Either way, I don't think adding a full build could hurt :)