Sync README with test workflow and add automatic ICO generation

[Copilot]

Summary of Repository Improvements

• Update README.md to use correct sccache version (v0.0.9 instead of v0.0.4)
• Update build.rs in hello-world example to use ico-builder for automatic ICO generation
• Review and improve code quality, readability, and robustness across the repository
  • Fixed all shellcheck warnings in bundle.sh
  • Properly quote GITHUB_OUTPUT variable to prevent globbing
  • Separate variable declarations from assignments to avoid masking return values
  • Use direct command execution instead of useless echo
  • Updated CONTRIBUTING.md with correct parameter count
  • Updated action versions in README to match test workflow (checkout@v5)
  • Simplified sccache configuration to use global env vars like the actual test example
• Test the changes to ensure they work correctly
• Run code review and security checks
• Fix ico-builder API usage (use IcoBuilder::default().add_source_file().build_file())

Changes Made

1. README Updates

• ✅ Updated mozilla-actions/sccache-action from v0.0.4 to v0.0.9 to match actual test workflow
• ✅ Updated actions/checkout from v4 to v5 to match actual test workflow
• ✅ Simplified sccache configuration to use global environment variables (cleaner approach used in test-examples.yml)
• ✅ Updated Windows resource embedding documentation to show automatic ICO generation using ico-builder
• ✅ Fixed ico-builder API usage in documentation

2. Automatic ICO Generation

• ✅ Added ico-builder as a build dependency in hello-world example
• ✅ Updated build.rs to use correct ico-builder API: IcoBuilder::default().add_source_file(png_path).build_file(ico_path)
• ✅ Build script now checks timestamps and only regenerates ICO if PNG is newer
• ✅ Updated example README to document the automated process
• ✅ No manual conversion required - just provide icon.png

3. Code Quality Improvements

• ✅ Fixed all shellcheck warnings in bundle.sh (100% clean)
• ✅ Properly quoted all GITHUB_OUTPUT variable references
• ✅ Separated variable declarations from command substitutions
• ✅ Removed unnecessary echo wrapper around dirname
• ✅ Updated CONTRIBUTING.md to show correct function parameters

4. Testing & Security

• ✅ Tested bundler script locally - works correctly
• ✅ Code review passed - no issues found
• ✅ CodeQL security scan passed - no vulnerabilities found
• ✅ Build succeeds with correct ico-builder API

All changes maintain backward compatibility and improve the developer experience by ensuring documentation matches actual implementation.

Original prompt

Update the README to reflect the actual test-example, currently it for example uses the wrong sccache version. Also ensure readability, code quality and robustness across the whole repository. Use ico-builder to automatically generate ico files in the buildscript.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[julcst]

@copilot look at the usage example of ico-builder and fix the CI test on Windows

[Copilot]

@copilot look at the usage example of ico-builder and fix the CI test on Windows

Fixed in 327cb9b. The correct ico-builder API uses:

ico_builder::IcoBuilder::default()
    .add_source_file(png_path)
    .build_file(ico_path)

Instead of the non-existent build_ico_from_png function. Updated both build.rs and README documentation.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• docs.rs
  • Triggering command: curl -s REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)