Skip to content

Fill out more fields on the fake failure response to try and avoid crash #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Imperiopolis merged 1 commit into from
Mar 13, 2026
Merged

Fill out more fields on the fake failure response to try and avoid crash #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions android/src/main/kotlin/xyz/juicebox/sdk/Client.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ class Client private constructor (
private fun createNative(configuration: Configuration, previousConfigurations: Array<Configuration>, authTokens: Map<RealmId, AuthToken>?): Long {
val httpSend = Native.HttpSendFn { httpClient, request ->
thread {
val response = Native.HttpResponse()
response.id = request.id
try {
val urlConnection = URL(request.url).openConnection() as HttpsURLConnection

Expand Down Expand Up @@ -166,9 +168,6 @@ class Client private constructor (
urlConnection.outputStream.write(it)
}

val response = Native.HttpResponse()

response.id = request.id
response.statusCode = urlConnection.responseCode.toShort()
response.headers = urlConnection.headerFields.filterKeys { it != null }.map { (key, values) ->
Native.HttpHeader(key, values.joinToString(","))
Expand All @@ -183,9 +182,10 @@ class Client private constructor (
Native.httpClientRequestComplete(httpClient, response)
} catch (t: Throwable) {
Log.e("JuiceboxClient", "Failed to make http call", t)
val fakeErrorResponse = Native.HttpResponse()
fakeErrorResponse.statusCode = -1
Native.httpClientRequestComplete(httpClient, fakeErrorResponse)
response.statusCode = -1
response.body = byteArrayOf()
response.headers = arrayOf()
Native.httpClientRequestComplete(httpClient, response)
}
}
}
Expand Down
Loading