Skip to content

Fix bannerHidesWhenScoringUnavailable CI flake #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jubishop merged 1 commit into from
May 25, 2026
Merged

Fix bannerHidesWhenScoringUnavailable CI flake #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions PodHavenTests/ViewModelTests/SearchRecommendationCollectorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,11 +968,18 @@ import Testing
}
)

// Advance time once, well beyond the engine's 400 ms cacheRebuild debounce.
// That fires buildContext (returns nil) and bumps scoringRevision. With
// the fix, awaitScoringContext returns and the banner transitions to
// .hidden; without it, the banner stays .loading forever.
await fakeSleeper.advanceTime(by: .seconds(5))
// The drain task may not yet have reached engine.start() → observation →
// scheduleCacheRebuild by the time the banner shows .loading. Wait for
// the engine's cacheRebuild debounce to register its sleep before
// advancing time, otherwise advanceTime jumps the clock past a not-yet-
// scheduled wakeTime and the rebuild never fires.
try await fakeSleeper.waitForSleepRequests(count: 1)

// Advance well beyond the cacheRebuild debounce. That fires buildContext
// (returns nil) and bumps scoringRevision. With the fix, awaitScoringContext
// returns and the banner transitions to .hidden; without it, the banner
// stays .loading forever.
await fakeSleeper.advanceTime(by: .seconds(10))
try await Wait.until(
{ @MainActor in collector.bannerState == .hidden },
{ @MainActor in
Expand Down
Loading