hummingbird: router metrics#62
Merged
Merged
Conversation
Add aditional test checking that the prometheus counters work as expected, in particular with demotion by token bucket checks.
Add a benchmark to show that calling ClassOfSize is cheap per packet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add several prometheus counters to measure Hummingbird packets forwarding:
router_priority_forwarded_pkts_total: priority packets forwarded.router_humm_processed_pkts_total: hummingbird packets processed (or seen).router_humm_flyover_pkts_total: humm. packets with flyover (initially with priority).router_humm_demoted_freshness_total: humm. packets demoted to best-effort due to unfreshness (stale timestamp).router_humm_demoted_expired_total: demoted packets due to expired reservation.router_humm_demoted_tokenbucket_total: demoted packets due to excessive bandwidth.Use new prometheus metrics in
router_priorityandsquic_hummingbirdacceptance tests.This change is