Skip to content

docs: review upstream fatihak/InkyPi for features to port (JTN-718)#556

Merged
jtn0123 merged 1 commit into
mainfrom
jtn0123/jtn-718-upstream-review
Apr 20, 2026
Merged

docs: review upstream fatihak/InkyPi for features to port (JTN-718)#556
jtn0123 merged 1 commit into
mainfrom
jtn0123/jtn-718-upstream-review

Conversation

@jtn0123
Copy link
Copy Markdown
Owner

@jtn0123 jtn0123 commented Apr 19, 2026

Summary

Structured review of upstream fatihak/InkyPi to identify features/fixes worth porting to our fork. No code ports in this PR — review doc + follow-up Linear issues only.

  • Merge base: 8d08acd (2025-12-12).
  • Upstream commits scanned since merge-base: 25.
  • Upstream open PRs scanned: 35.
  • Upstream merged PRs scanned (since 2025-04-19): 50+.
  • Decisions: 9 Port / 8 Maybe later / ~20 Rejected.

See docs/upstream-review-2026-04.md for the full shortlist, rationale per item, and porting sketches.

Follow-up Linear issues (filed for each "Port" item)

Issue Upstream Priority What
JTN-767 #561 Medium Plugin fallback logic & deprecation cleanup
JTN-768 #568 High Grayscale background color crash fix
JTN-769 #613 High Open-Meteo forecast day-label off-by-one
JTN-770 fatihak#663 Medium Google Keep plugin
JTN-771 #489 Low "Save as new instance" button
JTN-772 #451 Medium Run-once mode + on-frame error rendering
JTN-773 fatihak#623 Medium Mutable-default + security hardening batch
JTN-774 #600 Low image_url configurable download timeout
JTN-775 #598 Low Servo control plugin (rotating frame)

Test plan

  • Reviewer spot-checks that "Rejected (already have it)" claims are accurate for 3-4 items via grep in our tree.
  • Reviewer sanity-checks 1-2 "Port" items have enough detail in the Linear issue for another agent to pick up cold.

🤖 Generated with Claude Code

Scanned 25 upstream commits past our merge-base (8d08acd, 2025-12-12),
35 open PRs, and 50+ recently merged PRs on fatihak/InkyPi. Produced a
structured shortlist with Port / Maybe later / Rejected sections and
filed follow-up Linear issues JTN-767..JTN-775 for each Port item.

Doc: docs/upstream-review-2026-04.md

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

Warning

Rate limit exceeded

@jtn0123 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 37 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 37 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c349f207-2171-40e6-9208-c0bead6c0fdd

📥 Commits

Reviewing files that changed from the base of the PR and between f6ebb07 and 07f43b9.

📒 Files selected for processing (1)
  • docs/upstream-review-2026-04.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jtn0123/jtn-718-upstream-review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Memory diff vs base

Metric Base PR Delta
Peak RSS 29.10 MB 29.09 MB -16.0 KB
sys.modules count 584 584 0
Top 20 startup allocators
# Location Base PR Delta
1 lark/visitors.py:180 1.00 MB 4.00 MB +3.00 MB ⚠️
2 <frozen importlib._bootstrap>:488 5.09 MB 7.94 MB +2.85 MB ⚠️
3 attr/_make.py:226 2.03 MB 0 B -2.03 MB ⚠️
4 lark/lexer.py:215 2.00 MB 0 B -2.00 MB ⚠️
5 parsers/lalr_parser_state.py:105 3.00 MB 1.00 MB -2.00 MB ⚠️
6 lark/tree.py:67 2.00 MB 0 B -2.00 MB ⚠️
7 <frozen importlib._bootstrap_external>:757 6.56 MB 5.46 MB -1.10 MB ⚠️
8 lark/utils.py:326 1.01 MB 0 B -1.01 MB ⚠️
9 lark/visitors.py:347 0 B 1.00 MB +1.00 MB ⚠️
10 python3.12/dataclasses.py:473 0 B 1.00 MB +1.00 MB ⚠️
11 arrow/locales.py:2577 1.00 MB 0 B -1.00 MB ⚠️
12 lark/lexer.py:304 1.00 MB 0 B -1.00 MB ⚠️
13 python3.12/ast.py:52 1.00 MB 0 B -1.00 MB ⚠️
14 python3.12/typing.py:904 1.00 MB 0 B -1.00 MB ⚠️
15 werkzeug/local.py:531 1.00 MB 0 B -1.00 MB ⚠️
16 lark/tree.py:145 0 B 1.00 MB +1.00 MB ⚠️
17 attr/_make.py:1207 0 B 1.00 MB +1.00 MB ⚠️
18 re/_compiler.py:392 0 B 1.00 MB +1.00 MB ⚠️
19 lark/load_grammar.py:537 0 B 1.00 MB +1.00 MB ⚠️
20 lark/load_grammar.py:795 0 B 1.00 MB +1.00 MB ⚠️

JTN-610 · backend=base:memray, pr:memray · informational only, does not block merge. Hard RSS budgets are enforced separately by JTN-608.

@sonarqubecloud
Copy link
Copy Markdown

@jtn0123 jtn0123 merged commit 35bd9f5 into main Apr 20, 2026
36 checks passed
@jtn0123 jtn0123 deleted the jtn0123/jtn-718-upstream-review branch April 21, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant