Merged
Conversation
jhrcek
commented
Sep 20, 2025
| Source-Repository head | ||
| type: git | ||
| location: git://github.com/jtdaugherty/brick.git | ||
| location: http://github.com/jtdaugherty/brick |
Contributor
Author
There was a problem hiding this comment.
Fixing cabal check warning (executed as part of generated haskell-ci config)
Error: [git-protocol] Cloning over git:// might lead to an arbitrary code
execution vulnerability. Furthermore, popular forges like GitHub do not
support it. Use https:// or ssh:// instead.
jhrcek
commented
Sep 20, 2025
| echo " ghc-options: -Werror=missing-methods" >> cabal.project | ||
| echo " ghc-options: -Werror=missing-methods -Werror=missing-fields" >> cabal.project | ||
| if [ $((HCNUMVER >= 90400)) -ne 0 ] ; then echo "package brick" >> cabal.project ; fi | ||
| if [ $((HCNUMVER >= 90400)) -ne 0 ] ; then echo " ghc-options: -Werror=unused-packages" >> cabal.project ; fi |
Contributor
Author
There was a problem hiding this comment.
Recent version of haskell-ci adds this warning, which causes build error if there are unused dependencies in cabal file - for that reason removed all the unused dependencies to fix build failures caused by this warning.
Owner
|
Thank you for your work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like github actions CI hasn't been working for some time.
This is likely because the generated config uses ubuntu-20 images, which have been recently decomissioned (see https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/). Regenerating config with more recent version of haskell-ci should fix this (uses ubuntu 24 by default).