doc: clarify that Vty from customMainWithDefaultVty needs shutdown#530
Merged
jtdaugherty merged 1 commit intojtdaugherty:masterfrom Jun 22, 2025
Merged
Conversation
Owner
|
Yes, the As for the change here, my hope had been that the docs imply this in the chain of "Like " but I'm happy to merge this to make it clearer. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wondered whether perhaps
customMainWithDefaultVtyought to shut down the vty it creates, but since the return type includes the Vty, we probably should leave it as is, and just update the doc to clarify that it needs to be shut down.