Stroop task timeline - #69
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a1c0ba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jodeleeuw
requested changes
Jul 23, 2025
Contributor
Author
|
add flexible button positioning for main trials |
…ch-timelines into pr/lakshmanvishnu/69
Closed
farhat60
approved these changes
Nov 18, 2025
| } | ||
|
|
||
| // Add practice debrief | ||
| timeline.push(createPracticeDebrief()); |
Contributor
There was a problem hiding this comment.
bug: if practice_trials = 0, there is still shown a practice complete! screen after instructions.
to fix, just wrap with if (practice_trials > 0) { timeline.push(createPracticeDebrief());
|
|
||
| // Add createCelcomeAndInstruction function | ||
| if (show_welcome_and_instructions) { | ||
| timeline.push(createWelcomeAndInstructions(choice_of_colors)); |
Contributor
There was a problem hiding this comment.
change to createInstructions() per standardization
Contributor
There was a problem hiding this comment.
make sure to change in docs too lol
Contributor
|
remaining issue:
|
css is now specific to the timeline only, text is fully customizable, docs are updated and the package itself is cleaned up.
jodeleeuw
reviewed
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened a new branch of my forked repo which only has the stroop task timeline.