Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Update overrides to overwrite bad "map" in aws-sdk@2.4.0.json.#927

Open
fluffywaffles wants to merge 1 commit intojspm:masterfrom
fluffywaffles:master
Open

Update overrides to overwrite bad "map" in aws-sdk@2.4.0.json.#927
fluffywaffles wants to merge 1 commit intojspm:masterfrom
fluffywaffles:master

Conversation

@fluffywaffles
Copy link
Contributor

@fluffywaffles fluffywaffles commented Jun 27, 2016

If you don't set "map" to {}, you get

"map": { "./dist/aws-sdk.js": { "browser": "lib/browser.js" } }

Which hopelessly breaks everything, as "lib/browser.js" contains calls to require that the browser can't handle.

jspm run app still errors, but at least the browser build works again.

@fluffywaffles fluffywaffles changed the title Update overrides to overwrite bad "map". Update overrides to overwrite bad "map" in aws-sdk@2.4.0.json. Jun 27, 2016
@guybedford
Copy link
Member

This shouldn't be necessary with jspmNodeConversion: false present. Perhaps check #926 (comment)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants