Alter bootstrap registry entry to point to npm:bootstrap

[frederikschubert]

Follow up for this.

[guybedford]

Thanks so much for following up here @frederikschubert. I guess we should ensure that the npm:bootstrap@3 package works ok with the same override as the GitHub version before setting this up though?

[frederikschubert]

Yes. How could I test this?

[guybedford]

I guess just copying the v3 override from the github version and testing it imports ok would be enough:

{
  "main": "dist/js/bootstrap",
  "files": null,
  "shim": {
    "dist/js/bootstrap": {
      "deps": [
        "jquery",
        "tether"
      ],
      "exports": "$"
    }
  },
  "dependencies": {
    "jquery": "*",
    "tether": "github:HubSpot/tether@^1.1.1"
  }
}

[guybedford]

Perhaps add a jspmNodeConversion: false as well.

[frederikschubert]

Alright! I will try to do that tomorrow.

[guybedford]

Thanks so much!

[frederikschubert]

I have tested it with the override you suggested. I did create a self-executing bundle and it seems to work just fine. Though I have not performed any functional testing because I have no experience with the javascript part of bootstrap.

[jakeNiemiec]

👎 jspm i npm:bootstrap does function for multiple people (https://gitter.im/jspm/jspm?at=57618d0c7a851b587e6f1d50). Even after fiddling around with the overrides, the npm version just refuses to function properly. This is impossible to learn from simply installing it.

Feel free to test things out on here: https://github.com/jakeNiemiec/jspm_bootstrap . This is a bare bones implementation (loading bootstrap onto the page).

Quote of better explanation from #916 :

@guybedford It is broken right now, bootstrap@4.0.0-alpha.2 requires jquery below 3.0.0.
Using this as an example https://github.com/jakeNiemiec/jspm_bootstrap .

We are simply importing bootstrap https://github.com/jakeNiemiec/jspm_bootstrap/blob/master/src/index.js#L2

Desired outcome:

Everything loaded. Notice that jquery was properly included on the page, exported within bootstrap.

Lets try jspm i npm:bootstrap@4.0.0-alpha.2

Jquery no longer gets properly exported, it is loaded on the page after index.js executes (this is beyond the scope of my understanding).

Lets assume the user will try to install or include jquery to fix this according to the error jspm i jquery

😞 same error

At this point lets assume the user know that they need to override the format in the loaded jquery

This is due (in part) to "github:twbs/bootstrap@4.0.0-alpha.2" > "dependencies" > "jquery": "*",