fix: treat optional JSON Schema test suite cases as real tests (#913)#915
Merged
Conversation
DannyvdSluijs
force-pushed
the
feature/fix-optional-test-skipping
branch
from
89101d1 to
2791cb2
Compare
Previously, any optional test that threw an exception or produced the wrong validation result was silently skipped via markTestSkipped, making regressions in optional test coverage invisible in CI. Remove the two dynamic markTestSkipped blocks so optional tests are treated identically to required tests. The 76 currently-failing optional tests are added explicitly to the $skip allowlist with comments explaining why each group is not yet supported (bignum, float-overflow, ecmascript-regex, cross-draft, idn-email, idn-hostname, iri, iri-reference, regex format, relative-json-pointer). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DannyvdSluijs
force-pushed
the
feature/fix-optional-test-skipping
branch
from
89e8de7 to
3e7c291
Compare
DannyvdSluijs
force-pushed
the
feature/fix-optional-test-skipping
branch
from
3e7c291 to
13459c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, any optional test that threw an exception or produced the wrong validation result was silently skipped via markTestSkipped, making regressions in optional test coverage invisible in CI.
Remove the two dynamic markTestSkipped blocks so optional tests are treated identically to required tests. The 76 currently-failing optional tests are added explicitly to the $skip allowlist with comments explaining why each group is not yet supported (bignum, float-overflow, ecmascript-regex, cross-draft, idn-email, idn-hostname, iri, iri-reference, regex format, relative-json-pointer).
Related Issue
Fixes #913
Type of Change
Checklist
Additional Notes
None