Add the Posts example to illustrate a use for $lookup#8
Open
drpicox wants to merge 1 commit intojsonata-js:masterfrom
Open
Add the Posts example to illustrate a use for $lookup#8drpicox wants to merge 1 commit intojsonata-js:masterfrom
drpicox wants to merge 1 commit intojsonata-js:masterfrom
Conversation
andrew-coleman
requested changes
Mar 18, 2020
Member
andrew-coleman
left a comment
There was a problem hiding this comment.
This is good, but I would have used the following expression for the same effect:
posts.allIds@$P{
$P: byId.$lookup($P).comments.$lookup($$.comments.byId, $)
}
alternatively, if you can assume that the list of post IDs in posts.allIds is the same as the entries in posts.byId (and I'm happy if you can't assume this) then you could simplify it:
posts.byId.*{
id: comments.$lookup($$.comments.byId, $)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an example based on the recommendations for a redux state shape:
I have added this because I believe that a good example of
$lookupshould be beneficial.The added query is: