Skip to content

Add specification links to multipleOf.json - #999

Open
shivamsingh-007 wants to merge 101 commits into
json-schema-org:unifyfrom
shivamsingh-007:spec/minimum-property
Open

Add specification links to multipleOf.json#999
shivamsingh-007 wants to merge 101 commits into
json-schema-org:unifyfrom
shivamsingh-007:spec/minimum-property

Conversation

@shivamsingh-007

@shivamsingh-007 shivamsingh-007 commented Jul 20, 2026

Copy link
Copy Markdown

Summary

Add specification links to tests/draft2020-12/multipleOf.json, marking each test case as validating section 6.2.1 (multipleOf) of the JSON Schema Validation specification.

Related Issue

Fixes #699

What changed

  • Added "specification": [{"validation": "6.2.1"}] to all 5 test case objects in tests/draft2020-12/multipleOf.json

Why this approach

Proposed in PR #807 (type.json) as the format for this feature. Each test case gets its specification property immediately after description, as a small single-file PR per the issue's guidance.

Testing done

  • JSON syntax validated
  • Spec links validated via bin/annotate-specification-links -- all 5 resolve to the draft-bhutton-json-schema-validation-01 section 6.2.1

Checklist

  • Tests added/updated -- N/A (metadata-only change to test data)
  • Docs updated -- N/A (doc change within test file itself)
  • Lint/format passes -- N/A (JSON file)
  • Linked issue referenced (Fixes Add a specification property to test cases + tests #699)
  • No DCO required (MIT license, no CLA/DCO)
  • No unrelated changes bundled in

@shivamsingh-007
shivamsingh-007 requested a review from a team as a code owner July 20, 2026 10:31
Copilot AI review requested due to automatic review settings July 20, 2026 10:31
Copilot AI reviewed Jul 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@shivamsingh-007 shivamsingh-007 mentioned this pull request Jul 20, 2026
Open
5 tasks
@shivamsingh-007
shivamsingh-007 force-pushed the spec/minimum-property branch from bdebb65 to b8d0663 Compare July 27, 2026 16:17
@shivamsingh-007

shivamsingh-007 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Hi @jdesrosiers, this PR adds specification section references to the multipleOf.json test file ("specification": [{"validation": "6.2.1"}]). Would you mind taking a look when you get a chance?

codefromlani and others added 24 commits July 28, 2026 10:46
@codefromlani @jdesrosiers
Add validation suite checker and schema for the new validation/ direc…
5731541 
…tory (json-schema-org#912)

* Add validation suite checker and schema

* Refine Validation checker

* Fix validation test schema and error messages

* Handle unknown dialects
@codefromlani @jdesrosiers
Refactor validation schema as objects (json-schema-org#940)
e70e4d4
@codefromlani @jdesrosiers
Add default tests (json-schema-org#916)
b7d2316 
* Add default tests

* Add default validation tests

* Remove old default tests

* Add
@codefromlani @jdesrosiers
Add divisibleBy tests (json-schema-org#918)
77bb44c 
* Add divisibleBy tests

* Add divisibleBy validation tests
@codefromlani @jdesrosiers
Add maxItems tests (json-schema-org#920)
834366a 
* Add maxItems tests

* Add maxItems validation tests

* Remove compatibility 3
@codefromlani @jdesrosiers
Add extends tests (json-schema-org#919)
a04bcce 
* Add extends tests

* Add extends validation tests

* Remove old extends tests

* Update compatibility
@codefromlani @jdesrosiers
Add disallow tests (json-schema-org#917)
f28bb2c 
* Add disallow tests

* Add disallow validation tests

* Add

* Update compatibility
@codefromlani @jdesrosiers
Add maxLength tests (json-schema-org#921)
0effbe4 
* Add maxLength tests

* Add maxLength validation tests

* Remove compatibility 3

* Remove v1 tests
@codefromlani @jdesrosiers
Add minItems tests (json-schema-org#923)
b1f5581 
* Add minItems tests

* Add minItems validation tests

* Remove v1 tests
@codefromlani @jdesrosiers
Add minLength tests (json-schema-org#924)
e6cc6a8 
* Add minLength tests

* Add minLength validation tests

* Remove v1 tests
@codefromlani @jdesrosiers
Add properties tests (json-schema-org#926)
42b9602 
* Add properties tests

* Add properties validation tests

* Remove v1 tests
@codefromlani @jdesrosiers
Remove v1 tests (json-schema-org#949)
f5f8491
@codefromlani @jdesrosiers
Add maximum tests (json-schema-org#922)
a85f427 
* Add maximum tests

* Add maximum validation tests

* Merge exclusiveMaximum

* Update compatibility

* Remove v1 tests

* Remove old tests
@codefromlani @jdesrosiers
Add minimum tests (json-schema-org#925)
45e1732 
* Add minimum tests

* Add minimum validation tests

* Merge exclusiveMinimum

* Clean up

* Update compatibility
@codefromlani @jdesrosiers
Add recursiveRef tests (json-schema-org#963)
53dc810 
* Add recursiveRef tests

* Update validation/tests/recursiveRef.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani @jdesrosiers
Add infinite-loop-detection tests (json-schema-org#964)
5ae0504 
* Add infinite-loop-detection tests

* Update validation/tests/infinite-loop-detection.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani @jdesrosiers
Add pattern tests (json-schema-org#965)
e2ae308 
* Add pattern tests

* Update validation/tests/pattern.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani @jdesrosiers
Add additionalProperties tests (json-schema-org#966)
118495b 
* Add additionalProperties tests

* Update validation/tests/additionalProperties.json

* Update validation/tests/additionalProperties.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani @jdesrosiers
Add required tests (json-schema-org#968)
6f01dad 
* Add required tests

* Update validation/tests/required.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani @jdesrosiers
Fix validation suite schema (json-schema-org#969)
bac6ee3 
* Fix validation suite schema

* Update validation/validation-test-schema.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani @jdesrosiers
Add dependentRequired tests (json-schema-org#970)
d2c0c2e
@codefromlani @jdesrosiers
Add contains tests (json-schema-org#967)
03dd11a 
* Add contains tests

* Add minContains and maxContains tests
@codefromlani @jdesrosiers
Add boolean_schema tests (json-schema-org#974)
d23d5f4
@codefromlani @jdesrosiers
Add ref tests (json-schema-org#971)
d60583d 
* Add ref tests

* A few fixes and cleanup and moved some tests to legacy

* Move all tests that use

* Add ref-legacy tests

* Remove duplicate test case

* Some comptibility fixes, reordered tests to match ref.json, added id tests

* Alter recursive reference test so it can run on draft-03

* Fix a couple of mistakes

* Move all test that use /id

* Add refRemote tests

* Add refRemote legacy tests

* Refactor to ref, id, and anchor

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
codefromlani and others added 27 commits August 11, 2026 11:05
@codefromlani @jdesrosiers
Add optional format hostname tests (json-schema-org#1076)
249d62e 
* Add optional format hostname tests

* Add host-name, remove IDN tests for v1, sync tests across versions

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani
Add optional format regex tests (json-schema-org#1077)
99fd7f6
@codefromlani @jdesrosiers
Add optional format time tests (json-schema-org#1085)
eedb200 
* Add optional format time tests

* Update to match recent clarifications on leap second validity

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani
Add optional format uri tests (json-schema-org#1086)
c453e48
@codefromlani @jdesrosiers
Add optional format unknown tests (json-schema-org#1087)
c7c1de6 
* Add optional format unknown tests

* Update validation/tests/optional/format/unknown.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani
Add optional float-overflow tests (json-schema-org#1088)
388e357
@codefromlani @jdesrosiers
Optional id and id-legacy tests (json-schema-org#1089)
c6bcb87 
* Add optional id and id-legacy tests

* Move id-legacy tests

* Move anchor tests to anchor.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani @jdesrosiers
Add optional unknownKeyword tests (json-schema-org#1090)
82331cf 
* Add optional unknownKeyword tests

* Update validation/tests/optional/unknownKeyword.json

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani
Add optional json-pointer tests (json-schema-org#1091)
0e07e01
@codefromlani
Add optional format uri-reference tests (json-schema-org#1092)
4460479
@codefromlani
Add optional format uri-template tests (json-schema-org#1093)
46b706d
@codefromlani
Add optional content tests (json-schema-org#1094)
5dfc491
@codefromlani
Add optional format iri-reference tests (json-schema-org#1095)
6e44a02
@codefromlani @jdesrosiers
Add optional format idn-email tests (json-schema-org#1098)
f60404d 
* Add optional format idn-email tests

* Update description

* Apply suggestions from code review

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani @jdesrosiers
Add optional format idn-hostname tests (json-schema-org#1099)
2cb8da2 
* Add optional format idn-hostname tests

* Add missing test

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@jdesrosiers
Fix ecmascript-regex compatibilities
f5afdfa
@codefromlani
Add optional dependencies-compatibility tests (json-schema-org#1107)
7ab1725
@codefromlani
Add optional no-schema tests (json-schema-org#1108)
23c6b03
@codefromlani
Add optional format duration tests (json-schema-org#1109)
b4f3745
@codefromlani
Add optional format uuid tests (json-schema-org#1110)
bb16d4a
@codefromlani @jdesrosiers
Add optional dynamicRef tests (json-schema-org#1122)
fffbe95 
* Add optional dynamicRef tests

* Fix dynamic reference for v1 version of the test

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani
Validate external schemas (json-schema-org#1123)
78f9274
@codefromlani
Add optional format-assertion tests (json-schema-org#1124)
cea61d8
@codefromlani @jdesrosiers
Add optional cross-draft tests (json-schema-org#1126)
270e3b2 
* Add optional cross-draft tests

* Adjust compatibilities

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@codefromlani
Add optional format-annotation tests (json-schema-org#1127)
ee3d1ce
@codefromlani @jdesrosiers
Remove anchor v1 tests (json-schema-org#1128)
828dd39 
* Remove anchor v1 tests

* Restore formatting

---------

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>
@shivamsingh-007
Resolve unify merge conflicts: adopt unify versions, keep spec links …
e300f23 
…in multipleOf.json
@jdesrosiers
jdesrosiers force-pushed the unify branch 2 times, most recently from e31ffe8 to 050b02d Compare August 29, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shivamsingh-007 @codefromlani @jdesrosiers