Skip to content

fix some logics & docs#179

Merged
jsoizo merged 5 commits into
version_2_0_0from
v2-closing-audit-p0-p1
May 22, 2026
Merged

fix some logics & docs#179
jsoizo merged 5 commits into
version_2_0_0from
v2-closing-audit-p0-p1

Conversation

@jsoizo
Copy link
Copy Markdown
Owner

@jsoizo jsoizo commented May 22, 2026

Summary

  • Tighten v2 parsing semantics: throw CsvParseFormatException on EOF inside an unterminated quoted field, and reject LF / CR / U+2028 / U+2029 / U+0085 as CsvDialect delimiter / quote / escape characters.
  • Document v2 spec edges: clarify WriteQuoteMode.NON_NUMERIC as a digits-plus-at-most-one-dot lexical rule, and pin CsvFieldNumDifferentException.rowNum as a CSV row number (post skipEmptyLine filter) in README / Module.md / migration guide / KDoc.

Test plan

  • ./gradlew check (commonTest + JVM / JS / native targets)
  • Confirm Module.md file-API snippets compile against current public API
  • Confirm CsvDialect rejects LF / CR / U+2028 / U+2029 / U+0085 in delimiter / quoteChar / escapeChar
  • Confirm unterminated quoted field at EOF surfaces CsvParseFormatException on both String and chunked I/O paths

@jsoizo jsoizo changed the title fix: close out v2 audit P0-P2 follow-ups fix some logics & docs May 22, 2026
@jsoizo jsoizo merged commit ecaf608 into version_2_0_0 May 22, 2026
3 checks passed
@jsoizo jsoizo deleted the v2-closing-audit-p0-p1 branch May 22, 2026 15:27
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.37%. Comparing base (15aba08) to head (9aba37b).
⚠️ Report is 7 commits behind head on version_2_0_0.

Files with missing lines Patch % Lines
...mmonMain/kotlin/com/jsoizo/kotlincsv/CsvDialect.kt 64.28% 3 Missing and 2 partials ⚠️
...jsoizo/kotlincsv/reader/internal/SequenceParser.kt 42.85% 0 Missing and 4 partials ⚠️
...soizo/kotlincsv/writer/internal/SequenceEncoder.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           version_2_0_0     #179      +/-   ##
=================================================
- Coverage          94.87%   93.37%   -1.51%     
=================================================
  Files                 22       22              
  Lines                507      528      +21     
  Branches             116      122       +6     
=================================================
+ Hits                 481      493      +12     
- Misses                13       17       +4     
- Partials              13       18       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant