Add reader implementation for wasmJs.#135
Closed
gsteckman wants to merge 17 commits into
Closed
Conversation
chore: update README.md with new GitHub username jsoizo for links and badges chore: update build.gradle.kts with new GitHub username jsoizo for project URLs and developer name
Update usernames where they appear.
Change CI from CircleCI to GitHub Actions
Update Gradle to 8.1 and KMP to 1.7.21
Chanage namespace of code
Revert "Chanage namespace of code"
Version 1.10.0 and change groupId
Owner
|
Thanks for kicking off the wasm work! Closing because v2.0.0 rebuilt the I/O stack on kotlinx-io and added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extracted the CsvReader implementation for js into a common base class, CsvStringReader, and then reused it for both js and wasmJs actual implementations of CsvReader. js(BOTH) is deprecated, so I updated it to js(IR) in the build file.