Skip to content

Check project completion and plan deployment#42

Draft
jskoiz wants to merge 1 commit into
mainfrom
cursor/check-project-completion-and-plan-deployment-6f7e
Draft

Check project completion and plan deployment#42
jskoiz wants to merge 1 commit into
mainfrom
cursor/check-project-completion-and-plan-deployment-6f7e

Conversation

@jskoiz

@jskoiz jskoiz commented Oct 31, 2025

Copy link
Copy Markdown
Owner

This pull request contains changes generated by a Cursor Cloud Agent

Open in Cursor Open in Web

Co-authored-by: jkoizum <jkoizum@wgu.edu>
@cursor

cursor Bot commented Oct 31, 2025

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@jskoiz

jskoiz commented May 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review please run a code review on the latest PR head.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3c7331d1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread GO_LIVE_INSTRUCTIONS.md
"test:e2e-viewing-keys": "tsx test/e2e-viewing-keys.test.ts",
"test:viewing-keys": "tsx test/viewing-keys.test.ts",
"test:e2e-basic": "tsx test/e2e-basic-workflow.test.ts",
"prepublishOnly": "npm run build"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the failing build from prepublishOnly

In the documented beta publish path, this hook will run automatically before npm publish (npm docs: prepublishOnly runs before packing and only on publish), but the same commit documents that npm run build currently fails during DTS generation in DEPLOYMENT_READINESS_REPORT.md lines 73-77. Following these instructions therefore aborts the beta publish instead of tolerating the DTS failure; either fix the DTS build first or use a publish hook/build command that only requires the working CJS/ESM outputs.

Useful? React with 👍 / 👎.

Comment thread GO_LIVE_INSTRUCTIONS.md
#### 1.1 Update Root package.json

```bash
cd /workspace

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use paths relative to the repository root

These deployment commands hard-code /workspace, but I verified this checkout's package.json and sdk/package.json live under /workspace/zeraprivacy, so following the guide here edits the wrong directory and the later /workspace/sdk commands fail before publishing. This should be written relative to the repository root, e.g. start from the checkout directory and then cd sdk, so the guide works for actual clones and this repo layout.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants