Check project completion and plan deployment#42
Conversation
Co-authored-by: jkoizum <jkoizum@wgu.edu>
|
Cursor Agent can help with this pull request. Just |
|
@codex review please run a code review on the latest PR head. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3c7331d1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "test:e2e-viewing-keys": "tsx test/e2e-viewing-keys.test.ts", | ||
| "test:viewing-keys": "tsx test/viewing-keys.test.ts", | ||
| "test:e2e-basic": "tsx test/e2e-basic-workflow.test.ts", | ||
| "prepublishOnly": "npm run build" |
There was a problem hiding this comment.
Remove the failing build from prepublishOnly
In the documented beta publish path, this hook will run automatically before npm publish (npm docs: prepublishOnly runs before packing and only on publish), but the same commit documents that npm run build currently fails during DTS generation in DEPLOYMENT_READINESS_REPORT.md lines 73-77. Following these instructions therefore aborts the beta publish instead of tolerating the DTS failure; either fix the DTS build first or use a publish hook/build command that only requires the working CJS/ESM outputs.
Useful? React with 👍 / 👎.
| #### 1.1 Update Root package.json | ||
|
|
||
| ```bash | ||
| cd /workspace |
There was a problem hiding this comment.
Use paths relative to the repository root
These deployment commands hard-code /workspace, but I verified this checkout's package.json and sdk/package.json live under /workspace/zeraprivacy, so following the guide here edits the wrong directory and the later /workspace/sdk commands fail before publishing. This should be written relative to the repository root, e.g. start from the checkout directory and then cd sdk, so the guide works for actual clones and this repo layout.
Useful? React with 👍 / 👎.
This pull request contains changes generated by a Cursor Cloud Agent