Research privacy cash functionality and documentation#34
Conversation
Co-authored-by: jkoizum <jkoizum@wgu.edu>
|
Cursor Agent can help with this pull request. Just |
|
@codex review please run a code review on the latest PR head. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Fix research index links relative to this directory
These links are already inside docs/research, so ./docs/research/... resolves to docs/research/docs/research/...; I checked the repo tree and those targets do not exist, while the intended files are siblings of this README. Anyone using the documentation index will hit broken links for the reference docs until these are changed to sibling paths such as ./confidential-transfers.md.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ### Privacy Cash SDK | ||
|
|
||
| ```typescript | ||
| import { deposit, withdraw, getPrivateBalance } from 'privacy-cash-sdk'; |
There was a problem hiding this comment.
The quick-start examples import privacy-cash-sdk, but the official Privacy Cash frontend docs install/import the published package as privacycash (https://privacycash.mintlify.app/sdk/frontend), and npm view privacy-cash-sdk returns no package. Engineers following this reference will fail at the first install/import step, so the package name and example imports should be updated consistently.
Useful? React with 👍 / 👎.
| | Action | Fee | Who Pays | | ||
| |--------|-----|----------| | ||
| | **Deposit** | 0% + 0.005 SOL tx fee | User | | ||
| | **Withdraw** | 0.25% + 0.005 SOL | Relayer pays tx, deducts from withdrawal | |
There was a problem hiding this comment.
This fee table understates current Privacy Cash Solana withdrawal costs: the official user docs list Solana withdrawals as 0.006 SOL per recipient plus 0.35% of the withdrawal amount (https://privacycash.mintlify.app/), while this research uses 0.005 SOL plus 0.25% and the same numbers drive the later 1 SOL cost comparison. That can make the economics section choose the wrong winner, so the calculations should be updated from the current fee schedule.
Useful? React with 👍 / 👎.
2 participants
This pull request contains changes generated by a Cursor Cloud Agent