Skip to content

Add terminal shortcut#97

Merged
jsgrrchg merged 1 commit into
mainfrom
feature/terminal-shortcuts
May 17, 2026
Merged

Add terminal shortcut#97
jsgrrchg merged 1 commit into
mainfrom
feature/terminal-shortcuts

Conversation

@jsgrrchg
Copy link
Copy Markdown
Owner

Summary

Adds a dedicated terminal shortcut so power users can open a new terminal tab with Cmd+R on macOS and Ctrl+R on Linux/Windows when the developer terminal is enabled.

Details

  • Adds new_terminal to the central shortcut registry and settings shortcut list.
  • Wires the shortcut to the existing developer:new-terminal-tab command so it reuses the current developer mode and terminal enabled guard.
  • Adds the native macOS menu accelerator without introducing an Electron reload role.
  • Covers shortcut formatting, matching, opening behavior, and disabled-terminal behavior in tests.

Validation

  • npm test -- src/app/shortcuts/format.test.ts src/App.noteWindow.test.tsx
  • npx tsc -b --pretty false
  • git diff --check
  • Verified no role: reload was added.

@jsgrrchg jsgrrchg marked this pull request as ready for review May 17, 2026 08:29
@jsgrrchg jsgrrchg merged commit 0112ac2 into main May 17, 2026
8 checks passed
@jsgrrchg jsgrrchg deleted the feature/terminal-shortcuts branch May 17, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant